Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22063#discussion_r209135836
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/UDFRegistration.scala ---
    @@ -114,6 +114,7 @@ class UDFRegistration private[sql] (functionRegistry: 
FunctionRegistry) extends
           val types = (1 to x).foldRight("RT")((i, s) => {s"A$i, $s"})
           val typeTags = (1 to x).map(i => s"A$i: TypeTag").foldLeft("RT: 
TypeTag")(_ + ", " + _)
           val inputTypes = (1 to x).foldRight("Nil")((i, s) => 
{s"ScalaReflection.schemaFor[A$i].dataType :: $s"})
    +      val nullableTypes = (1 to x).foldRight("Nil")((i, s) => 
{s"ScalaReflection.schemaFor[A$i].nullable :: $s"})
    --- End diff --
    
    instead of having 2 list, shall we just keep a 
`Seq[ScalaReflection.Schema]` or `Seq[(DataType, Boolean)]`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to