Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3147#discussion_r20023680
--- Diff: network/yarn/pom.xml ---
@@ -54,5 +54,38 @@
<build>
<outputDirectory>target/scala-${scala.binary.version}/classes</outputDirectory>
<testOutputDirectory>target/scala-${scala.binary.version}/test-classes</testOutputDirectory>
+ <plugins>
--- End diff --
My understanding is that the shading plugin is primarily used to create
uber jars, and the shading dependency part is just a generally useful thing in
this process: http://maven.apache.org/plugins/maven-shade-plugin/. This is how
we create assembly jars in say the `example` and `core` modules, except the
difference here is that we don't actually need to shade any dependencies. I
think this is a pretty standard thing to do and I'm not sure if a comment is
necessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
