Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22038#discussion_r209163143
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercionSuite.scala
 ---
    @@ -1378,8 +1378,8 @@ class TypeCoercionSuite extends AnalysisTest {
         )
         ruleTest(inConversion,
           In(Literal("a"), Seq(Literal(1), Literal("b"))),
    -      In(Cast(Literal("a"), StringType),
    -        Seq(Cast(Literal(1), StringType), Cast(Literal("b"), StringType)))
    +      In(Cast(Literal("a"), IntegerType),
    --- End diff --
    
    mmmh...honestly in this case I'd rather say that string is a better type 
for the cast than int. I am not sure which is the result of casting "a" and "b" 
to int...


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to