GitHub user squito opened a pull request:

    https://github.com/apache/spark/pull/22071

    [SPARK-25088][CORE][MESOS][DOCS] Update Rest Server docs & defaults.

    ## What changes were proposed in this pull request?
    
    (a) disabled rest submission server by default in standalone mode
    (b) fails the standalone master if rest server enabled & authentication 
secret set
    (c) fails the mesos cluster dispatcher if authentication secret set
    (d) doc updates
    (e) when submitting a standalone app, only try the rest submission first if 
spark.master.rest.enabled=true
    
    otherwise you'd see a 10 second pause like
    18/08/09 08:13:22 INFO RestSubmissionClient: Submitting a request to launch 
an application in spark://...
    18/08/09 08:13:33 WARN RestSubmissionClient: Unable to connect to server 
spark://...
    
    
    
    
    I also made sure the mesos cluster dispatcher failed with the secret 
enabled, though I had to do that on slightly different code as I don't have 
mesos native libs around.
    
    ## How was this patch tested?
    
    I ran the tests in the mesos module & in core for org.apache.spark.deploy.*
    
    I ran a test on a cluster with standalone master to make sure I could still 
start with the right configs, and would fail the right way too.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/squito/spark rest_doc_updates

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22071.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22071
    
----
commit b4ca224095cb7fda6822c431465bfb7f48a4bb2d
Author: Imran Rashid <irashid@...>
Date:   2018-08-01T20:21:22Z

    [SPARK-25088][CORE][MESOS][DOCS] Update Rest Server docs & defaults.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to