Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22017#discussion_r209421292
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
 ---
    @@ -231,6 +231,15 @@ object TypeCoercion {
           })
       }
     
    +  /**
    +   * Similar to [[findTightestCommonType]] but with string promotion.
    +   */
    +  def findWiderTypeForTwoExceptDecimals(t1: DataType, t2: DataType): 
Option[DataType] = {
    --- End diff --
    
    On second thoughts, do we really need those? Seems like the current 
coercions rules don't contain possibly cast to null?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to