Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/3131#discussion_r20036358
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -68,19 +66,25 @@ private[hive] class HiveMetastoreCatalog(hive:
HiveContext) extends Catalog with
tableName: String,
alias: Option[String]): LogicalPlan = synchronized {
val (databaseName, tblName) = processDatabaseAndTableName(
-
db.getOrElse(hive.sessionState.getCurrentDatabase), tableName)
+ db.getOrElse(hive.sessionState.getCurrentDatabase), tableName)
--- End diff --
This is a nit, but if we are going to reformat IMHO the correct wrapping
here is:
```scala
val (databaseName, tblName) =
processDatabaseAndTableName(db.getOrElse(hive.sessionState.getCurrentDatabase),
tableName)
```
I think we should always break at the highest syntactic level (i.e., in
this case don't break a function from its arguments, but break the whole result
from what its being assigned to)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
