Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/21369#discussion_r209480296
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/ExternalAppendOnlyMap.scala
---
@@ -585,17 +591,24 @@ class ExternalAppendOnlyMap[K, V, C](
} else {
logInfo(s"Task ${context.taskAttemptId} force spilling in-memory
map to disk and " +
s"it will release
${org.apache.spark.util.Utils.bytesToString(getUsed())} memory")
- nextUpstream = spillMemoryIteratorToDisk(upstream)
+ val nextUpstream = spillMemoryIteratorToDisk(upstream)
+ assert(!upstream.hasNext)
hasSpilled = true
+ upstream = nextUpstream
true
}
}
+ private def destroy() : Unit = {
--- End diff --
nit: no space before `:`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
