Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/22075#discussion_r209487687 --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala --- @@ -90,9 +90,10 @@ trait CheckAnalysis extends PredicateHelper { u.failAnalysis(s"Table or view not found: ${u.tableIdentifier}") case operator: LogicalPlan => - // Check argument data types of higher-order functions downwards first because function - // arguments of the higher-order functions might be unresolved due to the unresolved - // argument data types, otherwise always claims the function arguments are unresolved. + // Check argument data types of higher-order functions downwards first. + // If the arguments of the higher-order functions are resolved but the type check fails, + // the argument functions will not get resolved, but we should report the argument type + // check failure instead of claiming the function arguments are unresolved. --- End diff -- "function arguments" -> "argument functions"?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org