Github user zhengruifeng commented on a diff in the pull request:
https://github.com/apache/spark/pull/21561#discussion_r209498032
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/BisectingKMeans.scala ---
@@ -151,13 +152,9 @@ class BisectingKMeans private (
this
}
- /**
- * Runs the bisecting k-means algorithm.
- * @param input RDD of vectors
- * @return model for the bisecting kmeans
- */
- @Since("1.6.0")
- def run(input: RDD[Vector]): BisectingKMeansModel = {
+
+ private[spark] def run(input: RDD[Vector],
+ instr: Option[Instrumentation]):
BisectingKMeansModel = {
--- End diff --
`instrumented` will create a new `Instrumentation`, and `instrumented` is
only used in ml
When mllib's impls is called, the `Instrumentation` will be passed as a
parameters, like what KMeans does
(https://github.com/apache/spark/blob/master/mllib/src/main/scala/org/apache/spark/ml/clustering/KMeans.scala#L362).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
