Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22009#discussion_r209823382
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
 ---
    @@ -76,41 +76,43 @@ object DataSourceV2Strategy extends Strategy {
       /**
        * Applies column pruning to the data source, w.r.t. the references of 
the given expressions.
        *
    -   * @return new output attributes after column pruning.
    +   * @return the created `ScanConfig`(since column pruning is the last 
step of operator pushdown),
    +   *         and new output attributes after column pruning.
    --- End diff --
    
    no it's not a project operator. If we want to support project pushdown 
(like `a + b`) in the future, it must be a different API. For project pushdown, 
operators order does matter.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to