Github user mengxr commented on the pull request:

    https://github.com/apache/spark/pull/3099#issuecomment-62230172
  
    @shivaram @tomerk I updated this PR and removed `modelParams`. The param 
traits are marked as `private[ml]`. As I mentioned, I have no particular 
preference here.
    
    I also added a simple text classification pipeline with (simple) tokenizer 
and hashingTF.
    
    For the codegen of getters/setters, I asked @heathermiller and @marmbrust . 
The answer is no at this time. The `@BeanProperty` logic is hard coded in the 
Scala compiler.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to