Github user kayousterhout commented on a diff in the pull request:

    https://github.com/apache/spark/pull/2968#discussion_r20047725
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala 
---
    @@ -56,6 +57,8 @@ class PairRDDFunctions[K, V](self: RDD[(K, V)])
       with SparkHadoopMapReduceUtil
       with Serializable
     {
    +  import PairRDDFunctions._
    --- End diff --
    
    Is this just for the reference to 
RECORDS_BETWEEN_BYTES_WRITTEN_METRIC_UPDATES on line 1093?  If so, I think it 
would be better to just use PairRDDFunctions directly there, since I think it 
makes the code a little easier to read not to have these blanket imports.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to