Github user mn-mikke commented on a diff in the pull request:
https://github.com/apache/spark/pull/22110#discussion_r210350632
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/TypeUtils.scala
---
@@ -73,4 +73,14 @@ object TypeUtils {
}
x.length - y.length
}
+
+ /**
+ * Returns true if elements of the data type could be used as items of a
hash set or as keys
--- End diff --
I'm open to any changes :) But if you want to explicitly mention the
```equals``` method, I would also mention ```hashCode``` generally needed for
usage in "hash" collections. But then this not 100% true for Spark's
specialized ```OpenHashSets``` and ```OpenHashMaps``` since they calculate hash
by themselves. WDYT?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
