GitHub user MrBago opened a pull request:

    https://github.com/apache/spark/pull/22139

    [SPARK-25149][GraphX] Update Parallel Personalized Page Rank to test with 
large vertexIds

    ## What changes were proposed in this pull request?
    
    runParallelPersonalizedPageRank in graphx checks that `sources` are <= 
Int.MaxValue.toLong, but this is not actually required. This check seems to 
have been added because we use sparse vectors in the implementation and sparse 
vectors cannot be indexed by values > MAX_INT. However we do not ever index the 
sparse vector by the source vertexIds so this isn't an issue. I've added a test 
with large vertexIds to confirm this works as expected.
    
    ## How was this patch tested?
    
    Unit tests.
    
    Please review http://spark.apache.org/contributing.html before opening a 
pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MrBago/spark remove-veretexId-check-pppr

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22139.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22139
    
----
commit e720eab9a435a738be9f08ccaefba2f4eb7dc867
Author: Bago Amirbekian <bago@...>
Date:   2018-08-17T23:43:25Z

    Update Parallel Personalized Page Rank to test with large vertexIds

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to