Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21087#discussion_r211080067
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/interface.scala
 ---
    @@ -164,9 +165,12 @@ case class BucketSpec(
         numBuckets: Int,
         bucketColumnNames: Seq[String],
         sortColumnNames: Seq[String]) {
    -  if (numBuckets <= 0 || numBuckets >= 100000) {
    +  def conf: SQLConf = SQLConf.get
    +
    +  if (numBuckets <= 0 || numBuckets > conf.bucketingMaxBuckets) {
    --- End diff --
    
    Since the condition is changed from `>` to `>=`, there is inconsistent 
between the condition and the error message.
    
    If this condition is true, the message is like `... but less than or equal 
to bucketing.maxBuckets ...`.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to