Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/21909#discussion_r211129911
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FailureSafeParser.scala
---
@@ -56,9 +58,15 @@ class FailureSafeParser[IN](
}
}
+ private val skipParsing = !isMultiLine && mode == PermissiveMode &&
schema.isEmpty
--- End diff --
not a big deal but I would leave a comment to explain why it's permissive
and non-miltiline only. I assume counts are known when it's actually parsed for
multiline cases, and counts should be given in any case when the mode is
permissive, right?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
