Github user arunmahadevan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22143#discussion_r211339535
  
    --- Diff: 
external/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaWriteTask.scala
 ---
    @@ -61,12 +63,30 @@ private[kafka010] class KafkaWriteTask(
     private[kafka010] abstract class KafkaRowWriter(
         inputSchema: Seq[Attribute], topic: Option[String]) {
     
    +  import scala.collection.JavaConverters._
    +
    +  protected val minOffsetAccumulator: 
collection.concurrent.Map[TopicPartition, Long] =
    +    new ConcurrentHashMap[TopicPartition, Long]().asScala
    --- End diff --
    
    why is this concurrent map?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to