Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/3172#discussion_r20056737
--- Diff:
network/shuffle/src/main/java/org/apache/spark/network/shuffle/ExternalShuffleBlockManager.java
---
@@ -56,16 +58,24 @@
// Single-threaded Java executor used to perform expensive recursive
directory deletion.
private final Executor directoryCleaner;
- public ExternalShuffleBlockManager() {
+ private final TransportConf conf;
+
+ public ExternalShuffleBlockManager(TransportConf conf) {
// TODO: Give this thread a name.
- this(Executors.newSingleThreadExecutor());
+ this(Executors.newSingleThreadExecutor(), conf);
}
// Allows tests to have more control over when directories are cleaned
up.
@VisibleForTesting
- ExternalShuffleBlockManager(Executor directoryCleaner) {
+ ExternalShuffleBlockManager(Executor directoryCleaner, TransportConf
conf) {
this.executors = Maps.newConcurrentMap();
this.directoryCleaner = directoryCleaner;
+ this.conf = conf;
+ }
+
+ @VisibleForTesting
--- End diff --
we probably don't need 2 VisibleForTesting constructors, do we? If someone
wants to provide an explicit Executor, they can damn well create their own
TransportConf. This is only done in a single unit test anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
