Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/22154#discussion_r211484616
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Projection.scala
---
@@ -180,7 +180,10 @@ object UnsafeProjection
try {
GenerateUnsafeProjection.generate(unsafeExprs,
subexpressionEliminationEnabled)
} catch {
- case CodegenError(_) =>
InterpretedUnsafeProjection.createProjection(unsafeExprs)
+ case _: Exception =>
+ // We should have already see error message in `CodeGenerator`
+ logWarning("Expr codegen error and falls back to interpreter mode")
--- End diff --
Nit: I prefer "falling back" instead of "falls back" here. e.g. "Expr
codegen error, falling back to interpreter mode"
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
