Github user Ishiihara commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3173#discussion_r20056877
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
    @@ -84,6 +84,10 @@ private[sql] abstract class SparkStrategies extends 
QueryPlanner[SparkPlan] {
               makeBroadcastHashJoin(leftKeys, rightKeys, left, right, 
condition, joins.BuildLeft)
     
           case ExtractEquiJoinKeys(Inner, leftKeys, rightKeys, condition, 
left, right) =>
    +        val mergeJoin = joins.MergeJoin(leftKeys, rightKeys, 
planLater(left), planLater(right))
    +        condition.map(Filter(_, mergeJoin)).getOrElse(mergeJoin) :: Nil
    +      
    +      case ExtractEquiJoinKeys(Inner, leftKeys, rightKeys, condition, 
left, right) =>
    --- End diff --
    
    You are right, the hash inner join will not be matched. I am trying to 
resolve to merge join on inner join. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to