Github user eyalfa commented on a diff in the pull request:
https://github.com/apache/spark/pull/17400#discussion_r211565064
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala
---
@@ -321,6 +321,58 @@ case class EnsureRequirements(conf: SQLConf) extends
Rule[SparkPlan] {
}
}
+ private def updatePartitioningByAliases(exprs: Seq[NamedExpression],
partioning: Partitioning)
+ : Partitioning = {
+ val aliasSeq = exprs.flatMap(_.collectFirst {
--- End diff --
@maropu , I didn't aim for supporting complex partitioning expressions
(which deserves its own separate PR), I meant that this code could introduce
regressions by 'over-capturing' nested aliases.
* my specific example is wrong since struct is transformed into a named
struct (alias is replaced by an explicit name).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
