Github user rednaxelafx commented on a diff in the pull request:
https://github.com/apache/spark/pull/22154#discussion_r211731921
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CodeGeneratorWithInterpretedFallback.scala
---
@@ -17,24 +17,10 @@
package org.apache.spark.sql.catalyst.expressions
-import org.codehaus.commons.compiler.CompileException
-import org.codehaus.janino.InternalCompilerException
-
-import org.apache.spark.TaskContext
+import org.apache.spark.internal.Logging
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.util.Utils
-/**
- * Catches compile error during code generation.
- */
-object CodegenError {
- def unapply(throwable: Throwable): Option[Exception] = throwable match {
- case e: InternalCompilerException => Some(e)
- case e: CompileException => Some(e)
--- End diff --
We didn't in the original PR. @maropu -san added one in this PR which is
great, plugs the hole.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
