Github user mccheah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22146#discussion_r211800326
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala
 ---
    @@ -96,3 +112,25 @@ private[spark] class KubernetesDriverBuilder(
         spec
       }
     }
    +
    +private[spark] object KubernetesDriverBuilder extends Logging {
    +  def apply(kubernetesClient: KubernetesClient, conf: SparkConf): 
KubernetesDriverBuilder = {
    +    conf.get(Config.KUBERNETES_DRIVER_PODTEMPLATE_FILE)
    +      .map(new File(_))
    +      .map(file => new KubernetesDriverBuilder(provideInitialSpec = conf 
=> {
    +        try {
    +          val sparkPod = KubernetesUtils.loadPodFromTemplate(
    +            kubernetesClient,
    +            file,
    +            Constants.DRIVER_CONTAINER_NAME)
    --- End diff --
    
    Unclear if these container names should be configurable.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to