Github user squito commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3079#discussion_r20062337
  
    --- Diff: core/src/main/scala/org/apache/spark/Partitioner.scala ---
    @@ -113,8 +117,12 @@ class RangePartitioner[K : Ordering : ClassTag, V](
       private var ordering = implicitly[Ordering[K]]
     
       // An array of upper bounds for the first (partitions - 1) partitions
    -  private var rangeBounds: Array[K] = {
    -    if (partitions <= 1) {
    +  @volatile private var valRB: Array[K] = null
    --- End diff --
    
    `valRD` is a kinda confusing name.  I think the convention would be to name 
it `_rangeBounds`.   Eg.
    
    
https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/FutureAction.scala#L111


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to