Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22146#discussion_r212400281
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/KubernetesClusterManager.scala
---
@@ -81,13 +88,17 @@ private[spark] class KubernetesClusterManager extends
ExternalClusterManager wit
.build[java.lang.Long, java.lang.Long]()
val executorPodsLifecycleEventHandler = new
ExecutorPodsLifecycleManager(
sc.conf,
- new KubernetesExecutorBuilder(),
+ KubernetesExecutorBuilder(kubernetesClient, sc.conf),
--- End diff --
I double checked and I don't think we use this variable inside
`ExecutorPodsLifecycleManager`, can you remove it?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
