Github user erikerlandson commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22146#discussion_r212469389
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/Config.scala
 ---
    @@ -225,6 +225,18 @@ private[spark] object Config extends Logging {
             "Ensure that major Python version is either Python2 or Python3")
           .createWithDefault("2")
     
    +  val KUBERNETES_DRIVER_CONTAINER_NAME =
    +    ConfigBuilder("spark.kubernetes.driver.containerName")
    --- End diff --
    
    I'm having mixed feelings about utility of convention vs configuration on 
this. Mostly just because the purpose of the PR is to prevent further spark 
configurations. If the feature leans on convention that first container in the 
list is to be the spark driver/executor, how confusing is that likely to be?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to