Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/22042#discussion_r212522664
--- Diff:
external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaMicroBatchSourceSuite.scala
---
@@ -161,6 +161,22 @@ abstract class KafkaSourceTest extends StreamTest with
SharedSQLContext with Kaf
s"AddKafkaData(topics = $topics, data = $data, message = $message)"
}
+ object WithKafkaProducer {
--- End diff --
nit: This is not creating a KafkaProducer .. as most `With***` methods. The
point of this is to force synchronization of the consumer. So maybe rename it
to `WithOffsetSync { ... }`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
