Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22218#discussion_r212784518
  
    --- Diff: 
core/src/main/scala/org/apache/spark/executor/ExecutorSource.scala ---
    @@ -73,6 +75,13 @@ class ExecutorSource(threadPool: ThreadPoolExecutor, 
executorId: String) extends
         registerFileSystemStat(scheme, "write_ops", _.getWriteOps(), 0)
       }
     
    +  // Dropwizard metrics gauge measuring the executor's process (JVM) CPU 
time.
    +  // The value is returned in nanoseconds, the method return -1 if this 
operation is not supported.
    +  val osMXBean = 
ManagementFactory.getOperatingSystemMXBean.asInstanceOf[OperatingSystemMXBean]
    +  metricRegistry.register(MetricRegistry.name("executorCPUTime" ), new 
Gauge[Long] {
    +    override def getValue: Long = osMXBean.getProcessCpuTime()
    --- End diff --
    
    This metric is useful for users?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to