Github user nrchakradhar commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22215#discussion_r212793906
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala
 ---
    @@ -60,4 +64,90 @@ private[spark] object KubernetesUtils {
       }
     
       def parseMasterUrl(url: String): String = url.substring("k8s://".length)
    +
    +  def formatPairsBundle(pairs: Seq[(String, String)], indent: Int = 1) = {
    +    // Use more loggable format if value is null or empty
    +    val indentStr = "\t" * indent
    +    pairs.map {
    +      case (k, v) => s"\n$indentStr $k: 
${Option(v).filter(_.nonEmpty).getOrElse("N/A")}"
    +    }.mkString("")
    +  }
    +
    +  /**
    +    * Given a pod output a human readable representation of its state
    --- End diff --
    
    nit. Adding a "," after pod make it better reading. Given a pod, output ...


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to