Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22236#discussion_r212833461
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/fpm/FPGrowth.scala ---
    @@ -361,20 +387,22 @@ private[fpm] object AssociationRules {
             dataset: Dataset[_],
             itemsCol: String,
             freqCol: String,
    -        minConfidence: Double): DataFrame = {
    +        minConfidence: Double,
    +        itemSupport: Map[Any, Long]): DataFrame = {
    --- End diff --
    
    Shouldn't this be a `Map[T, Long]`? it's required to be anyway below. It's 
worth adding to the scaladoc too.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to