Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22233#discussion_r213063623
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
    @@ -671,7 +674,7 @@ case class AlterTableRecoverPartitionsCommand(
             val value = ExternalCatalogUtils.unescapePathName(ps(1))
             if (resolver(columnName, partitionNames.head)) {
               scanPartitions(spark, fs, filter, st.getPath, spec ++ 
Map(partitionNames.head -> value),
    -            partitionNames.drop(1), threshold, resolver)
    +            partitionNames.drop(1), threshold, resolver, 
listFilesInParallel = false)
    --- End diff --
    
    @MaxGekk can we remove this `parmap` overload? It's pretty easy to cause 
deadlock. The `parmap` overload without the `ec` parameter is fine since it 
doesn't need a user specified thread pool.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to