Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22236#discussion_r213521021
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/fpm/FPGrowth.scala ---
    @@ -187,7 +191,8 @@ class FPGrowth @Since("2.2.0") (
           items.unpersist()
         }
     
    -    copyValues(new FPGrowthModel(uid, frequentItems)).setParent(this)
    +    copyValues(new FPGrowthModel(uid, frequentItems, 
parentModel.itemSupport, inputRowCount))
    --- End diff --
    
    Ah, so the total count n won't just equal the sum of the count of 
consequents, for example, because the frequent item set was pruned of 
infrequent sets? Darn, yeah you need to deal with the case where you know n and 
where you don't.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to