Github user mateiz commented on the pull request:

    https://github.com/apache/spark/pull/3099#issuecomment-62473807
  
    @mengxr I've looked through this and it looks good to me API-wise except 
for the small comments above. One important thing will be to have examples / 
tests that use each API in Java. Right now we do have them, but it's easy to 
miss when we add future APIs. Usually that's how something becomes tricky to 
call in Java, if there's a non-obvious effect of a change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to