Github user koeninger commented on the issue:
https://github.com/apache/spark/pull/22223
I think since the default behavior is still 1, it's probably ok to let
someone do what they want here
On Wed, Aug 29, 2018 at 3:51 PM, rezasafi <notificati...@github.com> wrote:
> *@rezasafi* commented on this pull request.
> ------------------------------
>
> In external/kafka-0-10/src/main/scala/org/apache/spark/streaming/kafka010/
> DirectKafkaInputDStream.scala
> <https://github.com/apache/spark/pull/22223#discussion_r213829668>:
>
> > @@ -154,7 +153,8 @@ private[spark] class DirectKafkaInputDStream[K, V](
> if (effectiveRateLimitPerPartition.values.sum > 0) {
> val secsPerBatch =
context.graph.batchDuration.milliseconds.toDouble / 1000
> Some(effectiveRateLimitPerPartition.map {
> - case (tp, limit) => tp -> Math.max((secsPerBatch *
limit).toLong, 1L)
> + case (tp, limit) => tp -> Math.max((secsPerBatch * limit).toLong,
> + Math.max(ppc.minRatePerPartition(tp), 1L))
>
> I just didn't want to break the reasoning behind SPARK-18371 to have at
> least 1 always. I didn't have any other reason for this. I can change it
to
> give the user the freedom.
>
> â
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/spark/pull/22223#discussion_r213829668>, or
mute
> the thread
>
<https://github.com/notifications/unsubscribe-auth/AAGAB2QkKLkQOCQoRTA0hArIsJIhY99Oks5uVv7LgaJpZM4WLq9l>
> .
>
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
