[GitHub] spark pull request #22048: [SPARK-25108][SQL] Fix the show method to display...

Wed, 29 Aug 2018 19:29:17 -0700 

Github user xuejianbest commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22048#discussion_r213888028
  
    --- Diff: core/src/test/scala/org/apache/spark/util/UtilsSuite.scala ---
    @@ -1184,6 +1184,25 @@ class UtilsSuite extends SparkFunSuite with 
ResetSystemProperties with Logging {
         
assert(Utils.getSimpleName(classOf[MalformedClassObject.MalformedClass]) ===
           "UtilsSuite$MalformedClassObject$MalformedClass")
       }
    +
    +  test("stringHalfWidth") {
    +    assert(Utils.stringHalfWidth(null) == 0)
    +    assert(Utils.stringHalfWidth("") == 0)
    +    assert(Utils.stringHalfWidth("ab c") == 4)
    +    assert(Utils.stringHalfWidth("1098") == 4)
    +    assert(Utils.stringHalfWidth("mø") == 2)
    +    assert(Utils.stringHalfWidth("γύρ") == 3)
    --- End diff --
    
    I found similar code in the `org.apache.commons.lang3.StringUtils` class.
    So the same test was added.
    In StringUtils 6934 line is comment:
    `* StringUtils.isNumeric("\u0967\u0968\u0969")  = true`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to