Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22179#discussion_r214127809
  
    --- Diff: pom.xml ---
    @@ -1770,6 +1770,10 @@
                 <groupId>org.apache.hive</groupId>
                 <artifactId>hive-storage-api</artifactId>
               </exclusion>
    +          <exclusion>
    +            <groupId> com.esotericsoftware</groupId>
    +            <artifactId>kryo-shaded</artifactId>
    --- End diff --
    
    Thank you for pinging me, @srowen . ORC uses Kryo only for writing/reading 
one ORC configuration, `orc.kryo.sarg`. The followings are the Spark's code 
indirect code path. I guess Kryo provides backward compatibility at lest, but 
I'll take a look at this PR today.
    - For new ORCFileFormat, 
[OrcInputFormat.setSearchArgument](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/orc/OrcFileFormat.scala#L159)
    - For old ORCFileFormat, 
[SearchArgument.toKryo](https://github.com/apache/spark/blob/master/sql/hive/src/main/scala/org/apache/spark/sql/hive/orc/OrcFileFormat.scala#L129)


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to