Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22233#discussion_r214203842
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
---
@@ -60,7 +60,8 @@ class HiveCatalogedDDLSuite extends DDLSuite with
TestHiveSingleton with BeforeA
protected override def generateTable(
catalog: SessionCatalog,
name: TableIdentifier,
- isDataSource: Boolean): CatalogTable = {
+ isDataSource: Boolean,
+ partitionCols: Seq[String] = Seq("a", "b")): CatalogTable = {
--- End diff --
Yeah, please don't overwrite a method with a default parameter. It's very
easy to use different default values then the value to pick up will depend on
the type you are using...
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
