Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22215#discussion_r214490999
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/KubernetesUtils.scala
---
@@ -60,4 +64,81 @@ private[spark] object KubernetesUtils {
}
def parseMasterUrl(url: String): String = url.substring("k8s://".length)
+
+ def formatPairsBundle(pairs: Seq[(String, String)], indent: Int = 1) :
String = {
+ // Use more loggable format if value is null or empty
+ val indentStr = "\t" * indent
--- End diff --
Can we prefer space-based indentation? Curious as to whether others have an
opinion about this.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
