Github user mccheah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22298#discussion_r214492080
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/features/bindings/JavaDriverFeatureStep.scala
 ---
    @@ -38,7 +39,8 @@ private[spark] class JavaDriverFeatureStep(
           .build()
         SparkPod(pod.pod, withDriverArgs)
       }
    -  override def getAdditionalPodSystemProperties(): Map[String, String] = 
Map.empty
    +  override def getAdditionalPodSystemProperties(): Map[String, String] =
    --- End diff --
    
    Again, not sure what our direction is going to be with respect to mixed 
pipelines throughout the cluster manager sections - if we should be supporting 
it in a first class way then perhaps we file a JIRA and we can discuss how the 
submission client should be refactored to support that.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to