Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22315#discussion_r214564353
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -1464,17 +1464,35 @@ case class ArrayContains(left: Expression, right:
Expression)
nullSafeCodeGen(ctx, ev, (arr, value) => {
val i = ctx.freshName("i")
val getValue = CodeGenerator.getValue(arr, right.dataType, i)
- s"""
- for (int $i = 0; $i < $arr.numElements(); $i ++) {
- if ($arr.isNullAt($i)) {
- ${ev.isNull} = true;
- } else if (${ctx.genEqual(right.dataType, value, getValue)}) {
- ${ev.isNull} = false;
- ${ev.value} = true;
- break;
+ def checkAndSetIsNullCode(body: String) = {
+ if (nullable) {
+ s"""
+ |if ($arr.isNullAt($i)) {
--- End diff --
How about the case `right.nullable = true` and
`left.nullable = false AND
left.dataType.asInstanceOf[ArrayType].containsNull = false`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
