Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21669#discussion_r215435605
--- Diff:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesDriverBuilder.scala
---
@@ -51,7 +51,11 @@ private[spark] class KubernetesDriverBuilder(
provideJavaStep: (
KubernetesConf[KubernetesDriverSpecificConf]
=> JavaDriverFeatureStep) =
- new JavaDriverFeatureStep(_)) {
+ new JavaDriverFeatureStep(_),
--- End diff --
Indentation here is super odd, but it is also odd for all the existing
code. But it's kinda hard to tell what's going on.
Seems like ` new JavaDriverFeatureStep(_)` is the body of a closure, in
which case it might be clearer to either keep in the same line as the `=`, or
just use braces and indent the block properly.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
