Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/3202#discussion_r20135662
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/types/util/DataTypeConversions.scala
---
@@ -131,6 +131,19 @@ protected[sql] object DataTypeConversions {
StructType(structType.getFields.map(asScalaStructField))
}
+ def guessTypeFromString(s:String): DataType = {
+ try {
+ val res = stringToTime(s)
--- End diff --
This function will be called against every string in json, so it should be
very fast. It should fail fast in most cases if the s is not a time, the path
in catch is extremely slow, see [1].
[1] http://stackoverflow.com/questions/299068/how-slow-are-java-exceptions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
