Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22337#discussion_r215894224
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/streaming/state/StateStoreRDDSuite.scala
---
@@ -49,8 +49,11 @@ class StateStoreRDDSuite extends SparkFunSuite with
BeforeAndAfter with BeforeAn
}
override def afterAll(): Unit = {
- super.afterAll()
- Utils.deleteRecursively(new File(tempDir))
+ try {
+ Utils.deleteRecursively(new File(tempDir))
+ } finally {
+ super.afterAll()
--- End diff --
I cannot find other state store suite. Could you please let me know the
name of these suites?
I intentionally changed the order since I saw this order
(`deleteRecursively() ->super.afterAll()`) in the following other places.
Since I am neutral on this order, it is ok to keep the original order like
```
try {
super.afterAll()
} finally {
Utils.deleteRecursively(new File(tempDir))
}
```
```
core/src/test/scala/org/apache/spark/rdd/RDDSuite.scala
core/src/test/scala/org/apache/spark/storage/DiskBlockManagerSuite.scala
sql/core/src/test/scala/org/apache/spark/sql/sources/CreateTableAsSelectSuite.scala
sql/core/src/test/scala/org/apache/spark/sql/sources/InsertSuite.scala
mllib/src/test/scala/org/apache/spark/ml/source/libsvm/LibSVMRelationSuite.scala
mllib/src/test/scala/org/apache/spark/ml/util/MLTest.scala
mllib/src/test/scala/org/apache/spark/ml/util/TempDirectory.scala
streaming/src/test/scala/org/apache/spark/streaming/rdd/MapWithStateRDDSuite.scala
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
