Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/2991#issuecomment-62522054
Things to do for this PR
1. Revert the change of separating out KafkaReceiver to minimize diff. Do
not want anything to affect the main code path.
2. Do not use `BlockGenerator.onStoreData`. Instead add synchronization in
the `KafkaReliableReceiver`, such that it synchronous add data to
BlockGenerator and update offset in the map. And also synchronously deals with
generated blocks by pushing it and committing Kafka offsets. Its best to have
all Kafka-specific complexity in the Kafka code, rather than pushing them down
into the BlockGenerator code. Later, depending on whether other receivers need
the functionality, we can push stuff into BlockGenerator.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
