Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/21849#discussion_r216059482
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/OutputRedirector.java ---
@@ -61,6 +62,10 @@ private void redirect() {
while ((line = reader.readLine()) != null) {
if (active) {
sink.info(line.replaceFirst("\\s*$", ""));
+ if (error == null && containsIgnoreCase(line, "Error") ||
containsIgnoreCase(line,
--- End diff --
nit: group the conditions so people don't have to remember how precedence
work. Also it looks better if you keep the whole call to `containsIgnoreCase`
in the same line.
Wouldn't you want to keep the last error, though, instead of the first one?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
