Github user maropu commented on a diff in the pull request: https://github.com/apache/spark/pull/22162#discussion_r216119774 --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala --- @@ -969,6 +969,20 @@ class DatasetSuite extends QueryTest with SharedSQLContext { checkShowString(ds, expected) } + test("SPARK-24442 Show should follow spark.show.default.number.of.rows") { + withSQLConf("spark.sql.show.defaultNumRows" -> "100") { + (1 to 1000).toDS().as[Int].show + } + } + + test("SPARK-24442 Show should follow spark.show.default.truncate.characters.per.column") { + withSQLConf("spark.sql.show.truncateMaxCharsPerColumn" -> "30") { + (1 to 1000).map(x => "123456789_123456789_123456789_") + .toDS().as[String] + .show --- End diff -- Plz compare the show result? https://github.com/apache/spark/blob/9241e1e7e66574cfafa68791771959dfc39c9684/sql/core/src/test/scala/org/apache/spark/sql/UDFSuite.scala#L326
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org