Github user mgaido91 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22373#discussion_r216326459
  
    --- Diff: 
mllib/src/test/scala/org/apache/spark/ml/feature/VectorAssemblerSuite.scala ---
    @@ -256,4 +256,9 @@ class VectorAssemblerSuite
         assert(runWithMetadata("keep", additional_filter = "id1 > 2").count() 
== 4)
       }
     
    +  test("SPARK-25371: VectorAssembler with empty inputCols") {
    --- End diff --
    
    I think so, after this patch this test passes, before it doesn't. I think 
it is helpful to avoid regressions like this in the future.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to