Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22364#discussion_r216329962
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/AttributeSet.scala
---
@@ -39,10 +41,15 @@ object AttributeSet {
/** Constructs a new [[AttributeSet]] given a sequence of [[Expression
Expressions]]. */
def apply(baseSet: Iterable[Expression]): AttributeSet = {
- new AttributeSet(
- baseSet
- .flatMap(_.references)
- .map(new AttributeEquals(_)).toSet)
--- End diff --
The name is ok. We still need to use the mutable set instead of `new
AttributeSet(sets.foldLeft(Set.empty[AttributeEquals])(_ ++ _.baseSet))`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
