Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22399#discussion_r216928860
--- Diff:
common/network-shuffle/src/test/java/org/apache/spark/network/shuffle/ExternalShuffleSecuritySuite.java
---
@@ -96,14 +96,14 @@ private void validate(String appId, String secretKey,
boolean encrypt)
ImmutableMap.of("spark.authenticate.enableSaslEncryption",
"true")));
}
- ExternalShuffleClient client =
- new ExternalShuffleClient(testConf, new TestSecretKeyHolder(appId,
secretKey), true, 5000);
- client.init(appId);
- // Registration either succeeds or throws an exception.
- client.registerWithShuffleServer(TestUtils.getLocalHost(),
server.getPort(), "exec0",
- new ExecutorShuffleInfo(new String[0], 0,
- "org.apache.spark.shuffle.sort.SortShuffleManager"));
- client.close();
+ try (ExternalShuffleClient client =
+ new ExternalShuffleClient(testConf, new TestSecretKeyHolder(appId,
secretKey), true, 5000)) {
+ client.init(appId);
+ // Registration either succeeds or throws an exception.
+ client.registerWithShuffleServer(TestUtils.getLocalHost(),
server.getPort(), "exec0",
+ new ExecutorShuffleInfo(new String[0], 0,
--- End diff --
ditto for indentation
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
