Github user skonto commented on a diff in the pull request:
https://github.com/apache/spark/pull/22405#discussion_r217215209
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsAllocatorSuite.scala
---
@@ -167,13 +167,23 @@ class ExecutorPodsAllocatorSuite extends
SparkFunSuite with BeforeAndAfter {
executorSpecificConf.executorId,
TEST_SPARK_APP_ID,
Some(driverPod))
- k8sConf.sparkConf.getAll.toMap == conf.getAll.toMap &&
+
+ // Set prefixes to a common string since
KUBERNETES_EXECUTOR_POD_NAME_PREFIX
+ // has not be set for the tests and thus KubernetesConf will use
a random
+ // string for the prefix, based on the app name, and this
comparison here will fail.
+ val k8sConfCopy = k8sConf
+ .copy(appResourceNamePrefix = "")
+ .copy(sparkConf = conf)
--- End diff --
fixed
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
